Category: Forum

Cannot edit an email address in a comment

I got an email from someone who had commented on my blog and who had supplied an email address and not a home page, therefore his email address was shown as a link next to his post. he emailed me to ask if i could remove or change his email address as he didnt want it to be harvested. I went to the post and to edit the said comment. I changed the email address to blank@blank.com and i got the standard “we dont take kindly to that sort of thing here” message. Read more

1.7.1 Comment bug

I have just found a bug in the comments processing in version 1.7.1. If you post a comment as an author you are required to send {AUTHNAME}_{PASSWORD} for the comment to succeed. The { brackets are not necessary but the underscore is.

The problem is that the password is displayed in the comment preview and also in the posted comment. To fix this change the following lines (around 335 in gm-comment.cgi ]

Code:

my %newComment = ();
$newComment{‘name’} = $IN{‘newcommentauthor’};

to ]

Code:

my %newComment = ();
my @authname = split(/_/,$IN{‘newcommentauthor’});
$newComment{‘name’} = $authname[0];

and around line 414:

Code:

my %comment = ();
$comment{‘name’} = $IN{‘newcommentauthor’};

to

Code:

my %comment = ();
my @authname = split(/_/,$IN{‘newcommentauthor’});
$comment{‘name’} = $authname[0];

 

I tested for that specific issue prior to releasing 1.7.1. I was wondering if you have author protection enabled? Read more

GM 1.7.1 – gmshortcutkeys missing

I enjoy using the shortcut keys provided by a simple Javascript addition to gm when using IE to allow me to do CTRL-SHIFT-A to add links quickly and also the same commands can be used to quickly bold or italic text. This features was in 1.3.0 and was deleted from 1.3.1 by accident by the previous maintainers. I posted a blog entry http://web.petefinnigan.com/weblog/archives/00000008.htm at the time about it.

The same code is still missing in 1.7.1 but the text describing how to use it is still there. To add this back go to gm-library.cgi lines 244 to 260 br]

Code:

date.setTime(date.getTime() – skew);
}
//–>
</SCRIPT>
#;$gmheadtagtwo = $gmheadtag;$gmheadtag .= qq#
</HEAD>

<body>#;

$gmheadtagtwo .= qq#
</HEAD>

<body>#;

change these lines to:

Code:

date.setTime(date.getTime() – skew);
}
#;$gmheadtagtwo = $gmheadtag;$gmheadtag .= qq#
//–>
</SCRIPT>

</HEAD>

<body>#;

$gmheadtagtwo .= qq#
function gmshortcutkeys() {
if ((parseInt(navigator.appVersion) >= 4) && (navigator.appName == “Microsoft Internet Explorer”)) {
if (event.ctrlKey != true) return;
gmselection = document.selection.createRange().text;
if (window.event.keyCode == 1) {
gminsertlink = prompt(“What do you want to link to?”, “http://”)
if (gminsertlink == null) return;
document.selection.createRange().text = ‘<a href=”‘ + gminsertlink + ‘”>’ + gmselection + ‘</a>’;
return;
}
if (window.event.keyCode == 2) {
document.selection.createRange().text = ‘<span style=”font-weight:bold;”>’ + gmselection + ‘</span>’;
return;
}
if (window.event.keyCode == 9) {
document.selection.createRange().text = ‘<span style=”font-style:italic;”>’ + gmselection + ‘</span>’;
return;
}
if (window.event.keyCode == 21) {
document.selection.createRange().text = ‘<span style=”text-decoration:underline;”>’ + gmselection + ‘</span>’;
return;
}
}
}

//–>
</SCRIPT>

</HEAD>

<body onKeyPress=”gmshortcutkeys();”>#;

My apologies on this Pete. I know you had mentioned this before 1.6.1 came out, and it fell off my plate. I will make sure this is in 1.7.2. Read more

1.7.1 – comment force check issue

I have been testing comments in 1.7.1 this evening and found an issue with the changes to gm-comments.cgi where you can specify that comments are forced through a preview and then a random string is generated to ask the user to enter it before the post is made to avoid some of the comment spam. This code is shown between lines 155 and 172:

Code:

if ( ($IN{‘gmpostpreview’} ne “”) || ($IN{‘gmpostpreview.x’} ne “”) ) {
&gm_previewcomment;
} else {if( $commentforcepreview eq Gm_Constants::YES && !exists( $IN{‘postit’} ) ){
## if force preview, check if var ‘postit’ only found on preview page
&gm_previewcomment;
}if( $commentverify eq ‘static’ || $commentverify eq ‘random’ ){
## if force preview, check if var ‘postit’ only found on preview page
&gm_forceverify;
}

&gm_addcomment;
&gm_freshenaftercomment;
}

The logic is that a user can press preview or submit, either way now if force preview is set the user previews the comment. The forceverify function is supposed to then display a random number for the user to enter and if this is successful then the comment is posted.

The issue is that the hidden value “postit” is never set. To fix this add the following line:

Code:

<INPUT TYPE=HIDDEN NAME=”postit” VALUE=”postit” />

to the “Confirmation Form Template” at the end just above the:

Code:

</form>

line. My tests showed this to work. Read more

GM 1.7.1 – RSS feed generation broken

I have just found that the gm-rss feed generator is broken if you upgrade to 1.7.1. I will fix it tomorrow evening as its 11:45 pm here and I need to go to work tomorrow. The issue is that gm-rss.cgi reads the config file entries by ordinal number and they have changed.

I will release a fix tomorrow but i am also working on a new built in feed generator that will be a core part of gm.

In 1.6.1 they changed to be name value pairs, is that whats causing the problem? Otherwise there shouldn’t have been any config file changes between 1.6.1 and 1.7.1.

Versions Affected: GreyMatter 1.7.1, 1.6.1, 1.3.1, and ? (presumably it affects all versions with the archive feature).
Severity: High (hard to fix) Read more

Tags and Categories

I didn’t want to move the old topic since it started out as a trouble shooting issue.
This is picking up the thread of original post:
http://greymatterforum.proboards82.com/index.cgi?board=gmtroubleshooting&action;=display&thread;=1173294298
—

I was thinking of doing the information rfp soon, once we hashed out some ideas.

I misled you with the search ting, I was thinking it would be static too. I think it fits in better with rest of gm. I was just thinking that the search templates addressed similar issues as Tags and Categories templates.

I guess I had tags and categories jumbled together. Thinking about it, does this definition work for everyone? Feel free to give input:

Categories: An entry can only have one category, categories can have 1 sub category. Categories are assigned only by the Author (or other admin that has editentry privileges).

Tags: An entry can have multiple tags, no sub tags. Tags added by users or authors (or both)? Tags factor into searching? Tags created by users or authors (or both)?

It seems like there are some commonalities though (again, everyone feel free to correct any assumptions I am making).

Both will need a screen to edit/add new. Both will need templates to display a list of all, templates to define what the static page with all marked entries should look like. Read more

GreyMatter 1.7.2.3

Due to a performance issue reported by Pete Finnigan in the bug forums, an updated version of the 1.7.2 release has been made available.

Versions Affected: 1.7.2, those with many entries, will be affected the most.

Issue: A fix for the issue of the ‘{{previous’ and ‘{{next’ links caused a performance delay of 45 seconds for each page rebuild. This delay would cause timeouts when rebuilding files. Read more

Active Development

How many people are actively developing greymatter?

What area of development are they focusing on?

That is a good question. Right now, as far as I know, its myself and Pete Finnigan.

I am focusing on refactoring the code to be more modular and easier to add enhancements. I have documented this in the gm_dev_guide.html that comes with GreyMatter. I also look for defects mentioned on the forums and attempt to fix them, depending on time and how extensive the fix will be.

I have setup two copies of Greymatter 1.7.1 on one of my web servers. The first one is my base line and the only changes I made to it is edit the templates so that they produce valid xhtml.

The second copy I am going thru the gm-library from line 1 on. My goal is have all web pages produced by Greymatter to be valid xhtml/css. I am using it to keep a log of all changes made.

Thats cool. Gm should be able to do valid xhtml/css. The Admin screens are very table heavy and I think it would be cool to move to styled divs. I am not anti-table, but they are using a trick I used to use, in which you create a nesting table with a 1% pad to create a border, so two tables instead of one div with border attribute.

Yes i would agree, I have not heard of anyone else (so far) apart from myself and Coldstone. I am working in feeds, comment moedreation queue and will also work on draft posts after that.

Looks interesting. I noticed you separated some of the stuff out. I only half finished moving the Admin css and js to the lib/Gm_Web.pm. Read more

Release GM 1.7.1 on 12/31/2006

Well its done and I did get more testing in so hopefully its not so buggy this time. Since the changes are not as drastic I hope to have avoided introducing more bugs.

Updated: Here are the changes for this release:

NEW FEATURE: Link Limit will block and/or ban commenters based on number of links in comment
NEW FEATURE: Force Preview will require that a commenter preview their post before submitting
NEW FEATURE: Require commenter to type pass-phrase, either a phrase provided or random letters
Fixed defect where installations with more than 1 connected files would not rebuild/repair the connected files: Read more

1 2